tests: switch to using toContain() to check for substring presence (#…

…32043)
twbs · Nov 2, 2020 · 71010cb · 71010cb
1 parent e0b8fcd
commit 71010cb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/js/tests/unit/tooltip.spec.js b/js/tests/unit/tooltip.spec.js
@@ -317,7 +317,7 @@ describe('Tooltip', () => {
 
         expect(tooltipShown).toBeDefined()
         expect(tooltipEl.getAttribute('aria-describedby')).toEqual(tooltipShown.getAttribute('id'))
-        expect(tooltipShown.getAttribute('id').indexOf('tooltip') !== -1).toEqual(true)
+        expect(tooltipShown.getAttribute('id')).toContain('tooltip')
         done()
       })
 

diff --git a/js/tests/unit/util/sanitizer.spec.js b/js/tests/unit/util/sanitizer.spec.js
@@ -20,7 +20,7 @@ describe('Sanitizer', () => {
 
       const result = sanitizeHtml(template, DefaultAllowlist, null)
 
-      expect(result.indexOf('script') === -1).toEqual(true)
+      expect(result).not.toContain('script')
     })
 
     it('should allow aria attributes and safe attributes', () => {
@@ -32,8 +32,8 @@ describe('Sanitizer', () => {
 
       const result = sanitizeHtml(template, DefaultAllowlist, null)
 
-      expect(result.indexOf('aria-pressed') !== -1).toEqual(true)
-      expect(result.indexOf('class="test"') !== -1).toEqual(true)
+      expect(result).toContain('aria-pressed')
+      expect(result).toContain('class="test"')
     })
 
     it('should remove tags not in allowlist', () => {
@@ -45,7 +45,7 @@ describe('Sanitizer', () => {
 
       const result = sanitizeHtml(template, DefaultAllowlist, null)
 
-      expect(result.indexOf('<script>') === -1).toEqual(true)
+      expect(result).not.toContain('<script>')
     })
 
     it('should not use native api to sanitize if a custom function passed', () => {