Skip to content

Commit

Permalink
Docs: Use proper <button> instead of faked <a> element for popover ex…
Browse files Browse the repository at this point in the history
…ample
  • Loading branch information
patrickhlauke committed Aug 2, 2020
1 parent a21f605 commit 7f738b5
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions site/content/docs/5.0/components/popovers.md
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ For proper cross-browser and cross-platform behavior, you must use the `<a>` tag
{{< /callout >}}

{{< example >}}
<a tabindex="0" class="btn btn-lg btn-danger" role="button" data-toggle="popover" data-trigger="focus" title="Dismissible popover" data-content="And here's some amazing content. It's very engaging. Right?">Dismissible popover</a>
<button type="button" class="btn btn-lg btn-danger" data-container="body" data-toggle="popover" data-trigger="focus" title="Dismissible popover" data-content="And here's some amazing content. It's very engaging. Right?">Dismissible popover</button>
{{< /example >}}

{{< highlight js >}}
Expand Down Expand Up @@ -302,7 +302,6 @@ Options for individual popovers can alternatively be specified through the use o
{{< partial "callout-danger-async-methods.md" >}}
{{< /callout >}}


#### show

Reveals an element's popover. **Returns to the caller before the popover has actually been shown** (i.e. before the `shown.bs.popover` event occurs). This is considered a "manual" triggering of the popover. Popovers whose title and content are both zero-length are never displayed.
Expand Down

0 comments on commit 7f738b5

Please sign in to comment.