Skip to content

Commit

Permalink
Dropdown — Don't use event delegation
Browse files Browse the repository at this point in the history
  • Loading branch information
rohit2sharma95 committed Mar 27, 2021
1 parent a1e00ee commit 8f9862e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions js/src/dropdown.js
Expand Up @@ -192,7 +192,7 @@ class Dropdown extends BaseComponent {
if ('ontouchstart' in document.documentElement &&
!parent.closest(SELECTOR_NAVBAR_NAV)) {
[].concat(...document.body.children)
.forEach(elem => EventHandler.on(elem, 'mouseover', null, noop))
.forEach(elem => EventHandler.on(elem, 'mouseover', noop))
}

this._element.focus()
Expand Down Expand Up @@ -427,7 +427,7 @@ class Dropdown extends BaseComponent {
// empty mouseover listeners we added for iOS support
if ('ontouchstart' in document.documentElement) {
[].concat(...document.body.children)
.forEach(elem => EventHandler.off(elem, 'mouseover', null, noop))
.forEach(elem => EventHandler.off(elem, 'mouseover', noop))
}

toggles[i].setAttribute('aria-expanded', 'false')
Expand Down

0 comments on commit 8f9862e

Please sign in to comment.