-
-
Notifications
You must be signed in to change notification settings - Fork 78.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Updates to .ratio selectors and docs
- Remove group selector for ratio items - Drop the .ratio-item entirely - Update docs to explain updated approach - Update Migration guide to reflect the latest
- Loading branch information
Showing
4 changed files
with
19 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9f60659
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making my typo-nerd a bit late on this, but we could use the multiplier character (
×
) instead of an X. It doesn't need escaping so is pretty straightforward: the only concern would be one wanting to write this class by hand, can be a bit more difficult.However, between copy-pasting from the docs or with in-browser and IDEs autocompletion, I don't think that's a big deal.
@mdo May I propose a PR for this or do you want to pass on this (which I'd understand)?
9f60659
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free @ffoodd!