Skip to content

Commit

Permalink
Remove explicit suppression of focus outline
Browse files Browse the repository at this point in the history
It's unclear what the reason for first introducing the original hack here (for `[tabindex="-1"]:focus {...}`) was. Seems something that may have been useful/necessary in SuitCSS, but don't think BS ever relied on this. #18330
It's since been modified to only apply when the browser wouldn't apply a visible outline anyway based on its own heuristics (the `:not(:focus-visible)` part) #28437

But now, thinking this through more...in browsers that do support this pseudo-selector, what this is essentially saying is redundant: don't apply outline in cases where a `tabindex="-1"` element receives focus but the browser wouldn't normally apply focus outline". at best, this is unnecessary. at worst, this actually overrides things an author may explicitly be trying to do with adding `:focus { outline: ... }` explicitly.
  • Loading branch information
patrickhlauke authored and mdo committed Feb 11, 2021
1 parent 4c7a3e8 commit df79aad
Showing 1 changed file with 0 additions and 14 deletions.
14 changes: 0 additions & 14 deletions scss/_reboot.scss
Original file line number Diff line number Diff line change
Expand Up @@ -57,20 +57,6 @@ body {
}


// Future-proof rule: in browsers that support :focus-visible, suppress the focus outline
// on elements that programmatically receive focus but wouldn't normally show a visible
// focus outline. In general, this would mean that the outline is only applied if the
// interaction that led to the element receiving programmatic focus was a keyboard interaction,
// or the browser has somehow determined that the user is primarily a keyboard user and/or
// wants focus outlines to always be presented.
// See https://developer.mozilla.org/en-US/docs/Web/CSS/:focus-visible
// and https://developer.paciellogroup.com/blog/2018/03/focus-visible-and-backwards-compatibility/

[tabindex="-1"]:focus:not(:focus-visible) {
outline: 0 !important;
}


// Content grouping
//
// 1. Reset Firefox's gray color
Expand Down

0 comments on commit df79aad

Please sign in to comment.