Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel data-touch="false" not working #28025

Closed
ezarowny opened this issue Jan 11, 2019 · 6 comments
Closed

Carousel data-touch="false" not working #28025

ezarowny opened this issue Jan 11, 2019 · 6 comments
Labels

Comments

@ezarowny
Copy link

I am unable to disable touch support for Carousels in Bootstrap 4.2.1. Adding an HTML attribute for data-touch="false" doesn't seem to change anything.

@ezarowny
Copy link
Author

Ah, maybe this line should have something like || !this.config.touch added to the conditional 🤔

@XhmikosR
Copy link
Member

/CC @Johann-S

@Johann-S
Copy link
Member

Thanks @ezarowny I made a PR to fix that 👍

@h0jeZvgoxFepBQ2C
Copy link

Is it possible that this is appearing again? Having the same problem now with 4.5.0?

@Yorik56
Copy link

Yorik56 commented Jul 29, 2020

touch-false

I made this modification on bootstrap.js, it's worked nice for me, hope it will help :p

@patrickhlauke
Copy link
Member

confirming that it seems we have a regression. opened a fresh ticket here #32629

@twbs twbs locked as resolved and limited conversation to collaborators Dec 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

6 participants