Regression: carousel data-touch="false" not working

[patrickhlauke]

A fresh version of this #28025 (comment)

It seems somehow the code that was added here #28046 has been lost at some point.

[edit: correction, as @rohit2sharma95 pointed out, the code is actually still there - i somehow managed to miss it while checking the code yesterday. so the problem may be deeper somehow]

[rohit2sharma95]

But the check (added in #28046) still exists in the main branch:

bootstrap/js/src/carousel.js

Lines 281 to 283 in a48a29a

	if (this._config.touch && this._touchSupported) {
	this._addTouchEventListeners()
	}

[patrickhlauke]

where is the actual data-touch data attribute queried? is that part of some more generic "grab anything that's a data attribute and shove it into the _config object" type logic?

[patrickhlauke]

as I always find it difficult to debug this sort of thing easily, and also because it would be nice to actually provide a live example, i made this provisional PR here to add a carousel without touch to the docs #32638

[patrickhlauke]

using the added example from #32638 I can confirm that https://deploy-preview-32638--twbs-bootstrap.netlify.app/docs/5.0/components/carousel/#suppressing-touch-swiping when tested on iOS, Android, and a Surface with touchscreen still reacts to touch/swipe despite the data-touch="false" attribute

[patrickhlauke]

turns out i was being a moron - this actually works in v5 if using the correct data-bs-touch="false". now wondering how to test the reported issue in 4.5...

[patrickhlauke]

ok, having now tested this in v4.5 as well, it seems there is no actual problem with data-touch="false". #32639

closing.