Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent vertical offset in IE 11 #29413

Merged
merged 3 commits into from Mar 31, 2020
Merged

Prevent vertical offset in IE 11 #29413

merged 3 commits into from Mar 31, 2020

Conversation

Trainmaster
Copy link

Fix #29245

@Trainmaster Trainmaster requested a review from a team as a code owner September 16, 2019 14:24
@ysds ysds added the css label Sep 26, 2019
@MartijnCuppens
Copy link
Member

I think a line-height: 0 would be more flexible than a fixed value here.

@Trainmaster Trainmaster force-pushed the fix-prevent-vertical-offset-in-ie11 branch from dd317bd to e0b6b71 Compare December 5, 2019 21:20
@MartijnCuppens MartijnCuppens added this to Inbox in v4.5.0 via automation Mar 31, 2020
@MartijnCuppens MartijnCuppens merged commit 45c99f7 into twbs:v4-dev Mar 31, 2020
@XhmikosR XhmikosR moved this from Inbox to Shipped in v4.5.0 Mar 31, 2020
@Jaygiri
Copy link

Jaygiri commented May 13, 2020

Thanks to IE 11. This is a breaking change for many.

@MartijnCuppens
Copy link
Member

Thanks to IE 11. This is a breaking change for many.

Please open a ticket with a demo if this is the case.

@Hiws Hiws mentioned this pull request Jun 20, 2020
Closed
@nelsonni nelsonni mentioned this pull request Jan 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartijnCuppens MartijnCuppens MartijnCuppens approved these changes

Assignees
No one assigned
Labels
css v4
Projects
No open projects
v4.5.0
  
Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Trainmaster @MartijnCuppens @Jaygiri @ysds