Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use javascript MouseEvent on checkbox button in 4.5 #30849

Closed
mrlife opened this issue May 18, 2020 · 2 comments
Closed

Cannot use javascript MouseEvent on checkbox button in 4.5 #30849

mrlife opened this issue May 18, 2020 · 2 comments

Comments

@mrlife
Copy link
Contributor

mrlife commented May 18, 2020

After upgrading from 4.4.1 to 4.5, the checkbox button no longer allows an onclick event on the checkbox. Reverting back to 4.4.1 fixes it. I believe the issue is from the event.preventDefault() (line 163) added in this pull request: #30388.

Here is a repro comparison with checkbox button test1 and regular checkbox test2.

4.4.1 (works): https://www.codeply.com/p/9DhKAgjsCP
4.5: https://www.codeply.com/p/v1lNDIWenF

OS: macOS 10.15.4
Browsers: Chrome 81.0.4044.138, Safari 13.1

@Lausselloic
Copy link
Contributor

I've tried to avoid preventing the event onclick onto the input, as a workarround you could catch the onclick event onto the label instead of the input waiting for the next release

@XhmikosR
Copy link
Member

Fixed by #30992

@XhmikosR XhmikosR removed this from Inbox in v4.5.1 Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants