Remove .nav-item from .nav-link to make it consistent #30973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdo
approved these changes
Jun 8, 2020
XhmikosR
reviewed
Jun 8, 2020
mdo
reviewed
Jun 8, 2020
Co-authored-by: Mark Otto <otto@github.com>
XhmikosR
added a commit
that referenced
this pull request
Jun 9, 2020
Remove the class `.nav-item` from `.nav-link` inside the non `ul` or `ol` based navs. This makes the consistency for `.nav-item` (This class will not be required on the `.nav-link`). `.nav-item` was only required when you use `.nav-fill` or `.nav-justified` on the `.nav`. In other cases, it was redundant. And the purpose of `.nav-item` on `.nav-link`s can be achieved via flexbox utilities as well (Mentioned in the docs also).
XhmikosR
added a commit
that referenced
this pull request
Jun 10, 2020
Remove the class `.nav-item` from `.nav-link` inside the non `ul` or `ol` based navs. This makes the consistency for `.nav-item` (This class will not be required on the `.nav-link`). `.nav-item` was only required when you use `.nav-fill` or `.nav-justified` on the `.nav`. In other cases, it was redundant. And the purpose of `.nav-item` on `.nav-link`s can be achieved via flexbox utilities as well (Mentioned in the docs also).
XhmikosR
added a commit
that referenced
this pull request
Jun 12, 2020
Remove the class `.nav-item` from `.nav-link` inside the non `ul` or `ol` based navs. This makes the consistency for `.nav-item` (This class will not be required on the `.nav-link`). `.nav-item` was only required when you use `.nav-fill` or `.nav-justified` on the `.nav`. In other cases, it was redundant. And the purpose of `.nav-item` on `.nav-link`s can be achieved via flexbox utilities as well (Mentioned in the docs also).
XhmikosR
added a commit
that referenced
this pull request
Jun 13, 2020
Remove the class `.nav-item` from `.nav-link` inside the non `ul` or `ol` based navs. This makes the consistency for `.nav-item` (This class will not be required on the `.nav-link`). `.nav-item` was only required when you use `.nav-fill` or `.nav-justified` on the `.nav`. In other cases, it was redundant. And the purpose of `.nav-item` on `.nav-link`s can be achieved via flexbox utilities as well (Mentioned in the docs also).
XhmikosR
added a commit
that referenced
this pull request
Jun 17, 2020
Remove the class `.nav-item` from `.nav-link` inside the non `ul` or `ol` based navs. This makes the consistency for `.nav-item` (This class will not be required on the `.nav-link`). `.nav-item` was only required when you use `.nav-fill` or `.nav-justified` on the `.nav`. In other cases, it was redundant. And the purpose of `.nav-item` on `.nav-link`s can be achieved via flexbox utilities as well (Mentioned in the docs also).
XhmikosR
added a commit
that referenced
this pull request
Jun 23, 2020
Remove the class `.nav-item` from `.nav-link` inside the non `ul` or `ol` based navs. This makes the consistency for `.nav-item` (This class will not be required on the `.nav-link`). `.nav-item` was only required when you use `.nav-fill` or `.nav-justified` on the `.nav`. In other cases, it was redundant. And the purpose of `.nav-item` on `.nav-link`s can be achieved via flexbox utilities as well (Mentioned in the docs also).
XhmikosR
added a commit
that referenced
this pull request
Jun 24, 2020
Remove the class `.nav-item` from `.nav-link` inside the non `ul` or `ol` based navs. This makes the consistency for `.nav-item` (This class will not be required on the `.nav-link`). `.nav-item` was only required when you use `.nav-fill` or `.nav-justified` on the `.nav`. In other cases, it was redundant. And the purpose of `.nav-item` on `.nav-link`s can be achieved via flexbox utilities as well (Mentioned in the docs also).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the class
.nav-itemfrom.nav-linkinside the nonulorolbased navs.This makes the consistency for
.nav-item(This class will not be required on the.nav-link)..nav-itemwas only required when you use.nav-fillor.nav-justifiedon the.nav. In other cases, it was redundant. And the purpose of.nav-itemon.nav-links can be achieved via flexbox utilities as well (Mentioned in the docs also).Closes #28423
Related #30880, #28117
(This PR covers #30912 as well)