Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove js/dist/index.js and js/dist/index.js.map since they seem unused? #31823

Closed
XhmikosR opened this issue Oct 2, 2020 · 3 comments
Closed

Remove js/dist/index.js and js/dist/index.js.map since they seem unused? #31823

XhmikosR opened this issue Oct 2, 2020 · 3 comments
Labels
js v4

Comments

@XhmikosR
Copy link
Member

XhmikosR commented Oct 2, 2020 •
edited

/CC @Johann-S the thing we were discussing the other day
@XhmikosR XhmikosR created this issue from a note in v4.5.3 (To do) Oct 2, 2020
@Johann-S
Copy link
Member

Johann-S commented Oct 2, 2020

we should do the same in v5 too

@Johann-S Johann-S added this to Inbox in v5.0.0-alpha3 via automation Oct 2, 2020
@XhmikosR
Copy link
Member Author

XhmikosR commented Oct 2, 2020

I'm mostly concerned about v4 because it really seems unused and the map file is definitely redundant and not auto-generated. Just keep in mind we don't want any accidental breaking changes in v4, though :)

@XhmikosR XhmikosR moved this from To do to Inbox in v4.5.3 Oct 2, 2020
@XhmikosR XhmikosR mentioned this issue Oct 6, 2020
Merged
@XhmikosR XhmikosR removed this from Inbox in v4.5.3 Oct 13, 2020
@XhmikosR XhmikosR added this to Inbox in v4.6.0 Oct 13, 2020
@XhmikosR XhmikosR mentioned this issue Oct 29, 2020
Merged
@XhmikosR
Copy link
Member Author

XhmikosR commented Nov 1, 2020

Fixed by #32001

@XhmikosR XhmikosR closed this as completed Nov 1, 2020
v5.0.0-alpha3 automation moved this from Inbox to Shipped Nov 1, 2020
@XhmikosR XhmikosR removed this from Shipped in v5.0.0-alpha3 Nov 1, 2020
@XhmikosR XhmikosR removed this from Inbox in v4.6.0 Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
js v4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@XhmikosR @Johann-S