Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V4 dev backports and updates #31840

Merged
merged 3 commits into from Oct 13, 2020
Merged

V4 dev backports and updates #31840

merged 3 commits into from Oct 13, 2020

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Oct 5, 2020

Refs #31823

@XhmikosR XhmikosR added the v4 label Oct 5, 2020
@XhmikosR XhmikosR added this to Inbox in v4.5.3 via automation Oct 5, 2020
@XhmikosR
Copy link
Member Author

XhmikosR commented Oct 5, 2020

This should restore the ES5 enforcement in tests @Johann-S

Enforce ES5 for tests
@XhmikosR
Copy link
Member Author

XhmikosR commented Oct 9, 2020

I left js/dist.index.js for the time being, although it does seem unused. We should revisit later if we need it and remove it if not.

@mdo
Copy link
Member

mdo commented Oct 12, 2020

I left js/dist.index.js for the time being, although it does seem unused. We should revisit later if we need it and remove it if not.

I see this is covered in #31823, so maybe we slate for v4.6.0? Do we need to warn folks at all?

@XhmikosR
Copy link
Member Author

I see this is covered in #31823, so maybe we slate for v4.6.0? Do we need to warn folks at all?

I intentionally kept index.js in v4-dev, since I can't be 100% sure if this will break something. But the sourcemap was outdated and moot for sure, hence why I decided to remove only that here :)

@XhmikosR XhmikosR merged commit d9f4bcf into v4-dev Oct 13, 2020
@XhmikosR XhmikosR deleted the v4-dev-xmr branch October 13, 2020 12:24
@XhmikosR XhmikosR moved this from Inbox to Shipped in v4.5.3 Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v4.5.3
Shipped
Development

Successfully merging this pull request may close these issues.

None yet

2 participants