V5 Offcanvas - Option to disable auto hide when offcanvas loses focus.

[scoizzle]

Currently in v5.0.0-beta 3:

Offcanvas will autohide when it loses focus. IE you click anywhere other than the offcanvas area.

What I'm suggesting:

Add data-bs-autohide boolean value to config options for Offcanvas.
Default for data-bs-autohide is true; to maintain existing compatibility.

Disable event registration for EVENT_CLICK_DISMISS when data-bs-autohide is set to false.

Alternatively, to allow changing of this property via the data attribute, allow the event to still be registered, but change the event handler to respect the autohide property.

Examples of the modifications required to implement change follow.

`
const Default = {
backdrop: true,
keyboard: true,
scroll: false,
autohide: true
}

const DefaultType = {
backdrop: 'boolean',
keyboard: 'boolean',
scroll: 'boolean',
autohide: 'boolean'
}
`

if (!this._config.autohide) { EventHandler.on(this._element, EVENT_CLICK_DISMISS, SELECTOR_DATA_DISMISS, () => this.hide()) }

[iainhallam]

If I understand what's being proposed, would this allow the offcanvas to be used more as a drawer in the user interface? The Material UI guidelines have drawer as a component that can be on-screen all the time:

https://material.io/components/navigation-drawer#standard-drawer

[scoizzle]

Yes, that is precisely what I am suggesting.

[GeoSot]

It is a valid feature.
We will try to take it into consideration or you may do a PR,
However keep it for now, till #33545 is merged. I will have it in mind too

[rajesh2kumar96]

#33605
@GeoSot Please review this PR and if anything is left let me know.

https://deploy-preview-33605--twbs-bootstrap.netlify.app/

[GeoSot]

@scoizzle @rajesh2kumar96

please give is a feedback if you still need this attitude, after version 5 release. Given the final backdrop utility, the offcanvas, closes only if we have a backdrop enabled. Are you ok with this behavior?

[rajesh2kumar96]

Hi, @GeoSot 🙂

I created the PR at that time when the issue could be reproduced. Although now the behavior has been changed, you should keep the ability to close the offcanvas by clicking outside it and keep it configurable. And it is just my opinion you guys are the maintainer it is definitely your call to make the proper decision.

[scoizzle]

I would say that the new behavior is what would be desirable and is an acceptable alternative to what I suggested.