Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StackBlitz Popovers and Tooltips examples #36449

Merged

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented May 27, 2022

Step 2 of #36391

This PR contains

  • New stackblitz option for the example shortcode
  • Rename js_snippet to stackblitz_add_js option for the example shortcode in order to identify easily what's related to StackBlitz
  • Rewrite the example shortcode's documentation and reorder the options
  • Hide the StackBlitz edit button of the first Popover example and use data-bs-title instead of title for the other Popover examples as discussed in Allow popovers examples to be tried on StackBlitz #36127 (comment)
  • ⚠️ Use data-bs-title instead of title for the Tooltip and Popover examples

Live previews

Popovers

Tooltips

@julien-deramond julien-deramond marked this pull request as ready for review May 27, 2022 14:57
@julien-deramond julien-deramond requested a review from a team May 27, 2022 14:58
@GeoSot GeoSot force-pushed the main-jd-refine-popovers-and-tooltips-examples-for-stackblitz branch from c25eb38 to 5ac36b6 Compare May 31, 2022 10:39
@julien-deramond
Copy link
Member Author

Following a discussion with @GeoSot a4153f4 contains the following modifications:

  • Removing of stackblitz param for the example shortcode only used in one example to simplify the use of this shortcode
  • It implies that all popovers and tooltips examples in the doc use data-bs-title instead of title
  • A reusable warning callout is in place (wording should be improved; if you have a better way to explain it don't hesitate :) )

@GeoSot GeoSot force-pushed the main-jd-refine-popovers-and-tooltips-examples-for-stackblitz branch from e40ed53 to 31ac201 Compare June 9, 2022 17:59
@GeoSot
Copy link
Member

GeoSot commented Jun 9, 2022

I think is fine now. Thanks a lot @julien-deramond 😄
@mdo if you are ok with it, lets merge it

@GeoSot GeoSot added this to In progress in v5.2.0-stable via automation Jun 20, 2022
@GeoSot GeoSot moved this from In progress to Reviewer approved in v5.2.0-stable Jun 20, 2022
@GeoSot GeoSot force-pushed the main-jd-refine-popovers-and-tooltips-examples-for-stackblitz branch from 31ac201 to 48a081f Compare June 20, 2022 12:12
@mdo mdo merged commit cfabeb7 into main Jun 20, 2022
v5.2.0-stable automation moved this from Reviewer approved to Done Jun 20, 2022
@mdo mdo deleted the main-jd-refine-popovers-and-tooltips-examples-for-stackblitz branch June 20, 2022 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.2.0-stable
  
Done
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants