Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix popover live demo to use data-bs-title instead of title #36613

Merged
merged 1 commit into from Jun 21, 2022

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Jun 20, 2022

馃槄 Forgot to update one example in #36449. This live demo example must use data-bs-title instead of title for consistency with the other examples and the callout message, and for the title to be displayed in StackBlitz.

Before, if "Edit on StackBlitz" button is clicked, the title won't be displayed in StackBlitz after clicking on the "Click to toggle popover".

Live preview

/CC @GeoSot

@julien-deramond julien-deramond added this to In progress in v5.2.0-stable via automation Jun 20, 2022
v5.2.0-stable automation moved this from In progress to Reviewer approved Jun 20, 2022
@julien-deramond julien-deramond merged commit a877c5d into main Jun 21, 2022
@julien-deramond julien-deramond deleted the main-jd-fix-stackbliz-popover-example branch June 21, 2022 05:39
v5.2.0-stable automation moved this from Reviewer approved to Done Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.2.0-stable
  
Done
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants