Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: remove unused _algolia.scss #36477

Merged
merged 1 commit into from Jun 1, 2022
Merged

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Jun 1, 2022

If I'm not mistaken the CSS used for Algolia search is now in _search.scss and not anymore in _algolia.scss. So this file could be removed from the repo.

Live preview

Check if there are no regressions in the Algolia search modal.

Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aww yeah, love a solidly red diff. Thanks for catching this!

v5.2.0-stable automation moved this from In progress to Reviewer approved Jun 1, 2022
@mdo mdo force-pushed the main-jd-remove-unused-algolia-scss branch from bd2fd46 to 02f8ce9 Compare June 1, 2022 19:44
@mdo mdo force-pushed the main-jd-remove-unused-algolia-scss branch from 02f8ce9 to 68a2a4a Compare June 1, 2022 21:15
@mdo mdo merged commit ac89c36 into main Jun 1, 2022
v5.2.0-stable automation moved this from Reviewer approved to Done Jun 1, 2022
@mdo mdo deleted the main-jd-remove-unused-algolia-scss branch June 1, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.2.0-stable
  
Done
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants