chore/merge-main: finish remaining modifications after Bootstrap design doc refactoring #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sign doc refactoring
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Merged
This comment was marked as resolved.
This comment was marked as resolved.
julien-deramond
commented
Jun 22, 2022
julien-deramond
commented
Jun 22, 2022
julien-deramond
deleted the
main-jd-fix-all-remaining-tasks-after-design-doc-refactoring
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will gather the remaining tasks and comments from #1247 and #1241 that were merged before my holidays in order for the developers to test this new design doc refacto before the 5.2.0 release.
////////////////////////////////////////////////////////////comments (e31014f)<!---------------------------------------------------->comments (e31014f).table-guidelinescould be removed (0301194).bd-gutter, but might be difficult to handle with Bsadded: "5.1"and/oradded: "5.2"on top of new Markdown files for Boosted for all new pages created specically (c47350d) Added the new components (not the rating stars -> need to have its own page ?) + No new components in 5.1role="group"in Boosted. There were a lot of them compared to Bootstrap. Check with the a11y team if it is OK to have removed them. Asked -> Not necessary but could help people to not forget it when important, do we need to revert (Doc: removerole="group"from some split drop* buttons twbs/bootstrap#36212) ?.text-bg-infofor the badge and in all headers examples*-darkrule.tabindex!!!After the merge
body > div.position-fixed:last-of-type) in the Wiki to fixsite/layouts/_default/docs.html><div class="position-fixed"><input type="text" tabindex="-1"></div>