Add missing CSS vars for .navbar-nav
#36689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mdo
approved these changes
Jul 7, 2022
|
Hello @julien-deramond, do you know when this is going to be released?. I installed boostrap 5 5.2.0-beta1 via npm. And this is causing an issue on my project. Not sure when the next version is going to be released with this fix?. Regards. |
|
Hey @Jps-Yoda. This patch will be in the v5.2.0 (stable release). I don't have have a fixed release date to share but hopefully in a couple of days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While answering to #36684, I may have spotted an issue regarding the definition of
--#{$prefix}nav-link-font-sizeand--#{$prefix}nav-link-font-weightin.navbar-nav.Without this fix, locally, if you change this in
_variables.css:The change is only observable in pages like
/docs/5.2/components/navs-tabs/that use.navand.nav-links inside.The change is not observable in the main header of the docs for example that use
.navbar-navand.nav-linkss inside.With this fix we can see the big bold font everywhere where we have
.nav|.navbar-navand.nav-links inside.