Docs: add blank target and noopener rel to footer external links #38894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
mdo
approved these changes
Jul 12, 2023
mdo
deleted the
main-jd-add-target-blank-and-rel-noopener-to-footer-links
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
target="_blank"andrel="noopener"to all external links in the documentation.Note that subdomains of
getbootstrap.comare considered internal links and are not affected by this change (like in the header).Motivation & Context
External links are already using
target="_blank"andrel="noopener"in the header for external links. This PR does the same thing for the footer for consistency and UX reasons.Type of changes
Checklist
npm run lint)Live previews