Link underlines #15316
Closed
Link underlines #15316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per #15304 this removes the indiscriminate ``text-decoration:none`` used for all links - and then reintroduces it for specific cases where the link-like nature of a link is clear enough from usage/context. Plus it adds explicit ``text-decoration:underline`` in specific situation ``<button class="btn-link">``
from the actual less files, customizer, and less decoumentation
|
Super exciting! This will be very helpful. |
| @@ -34,8 +34,6 @@ | |||
| @link-color: @brand-primary; | |||
| //** Link hover color set via `darken()` function. | |||
| @link-hover-color: darken(@link-color, 15%); | |||
| //** Link hover decoration. | |||
| @link-hover-decoration: underline; | |||
There was a problem hiding this comment.
Might not want to drop the variable declaration right away. Users of the Less files may rely on it for whatever reason, so it'd need time to deprecate. Not using it internally would suffice I think.
There was a problem hiding this comment.
Yeah, add a comment about it being deprecated (see the @screen-* variables for examples), but don't delete it.
|
This is likely only going to make its appearance in v.4...closing for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #15304 this removes the indiscriminate
text-decoration:noneused for all links - and then reintroduces it for specific cases where the link-like nature of a link is clear enough from usage/context.Plus it adds explicit
text-decoration:underlinein specific situation<button class="btn-link">