Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change list group item action cursor to pointer #21935

Closed
wants to merge 1 commit into from
Closed

change list group item action cursor to pointer #21935

wants to merge 1 commit into from

Conversation

bardiarastin
Copy link

No description provided.

@patrickhlauke
Copy link
Member

care to explain why? we're trying to avoid explicitly setting cursor, as that should be taken care of by correct use of most appropriate html element (e.g. a link)

@bardiarastin
Copy link
Author

bardiarastin commented Feb 7, 2017

we use pointer cursor to tell the user that the item is clickable , in spa javascript frameworks using a tag makes trouble with Routers so i taught that we're using this class most often times for click stuff , then it would be nice if cursor was pointer by default.
sorry for not providing details in description .

@patrickhlauke
Copy link
Member

if your action items act as links, but you can't use actual <a href...> elements, then i'd suggest adding extra cursor:pointer styles yourself to your additional CSS.

if the action items act as buttons (triggering something on the current page, rather than navigating to a new page / part of the current page, like buttons), then generally you want to keep the cursor as default - see reasoning behind #21812)

so for now, i don't think we'd want to force this in bootstrap core itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants