Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devDependencies. #29281

Merged
merged 2 commits into from
Aug 23, 2019
Merged

Update devDependencies. #29281

merged 2 commits into from
Aug 23, 2019

Conversation

XhmikosR
Copy link
Member

No description provided.

@XhmikosR XhmikosR requested a review from Johann-S August 19, 2019 13:31
@XhmikosR XhmikosR added this to Inbox in v5 via automation Aug 19, 2019
@XhmikosR
Copy link
Member Author

XhmikosR commented Aug 19, 2019

Hmm, it seems the new ESLint version introduce some false errors, I'll wait for a fix.

Upstream issue: eslint/eslint#12117

@tmorehouse
Copy link
Contributor

Upstream with babel-eslint: babel/babel-eslint#791

yakov116 referenced this pull request in sindresorhus/eslint-plugin-unicorn Aug 19, 2019
@XhmikosR XhmikosR force-pushed the master-xmr-deps branch 4 times, most recently from b7437bd to 2971db9 Compare August 23, 2019 06:57
Kept `eslint@6.1.0` since the newer versions have a bug.
@XhmikosR XhmikosR marked this pull request as ready for review August 23, 2019 07:30
@XhmikosR
Copy link
Member Author

Locked eslint to 6.1.0 but applied the eslint-utils update for the vulnerabilities fix.

Not sure when the bug will be fixed, so we can go with this in the meantime.

v5 automation moved this from Inbox to Approved Aug 23, 2019
@XhmikosR XhmikosR merged commit 1a9b120 into master Aug 23, 2019
v5 automation moved this from Approved to Shipped Aug 23, 2019
@XhmikosR XhmikosR deleted the master-xmr-deps branch August 23, 2019 23:47
lucanos pushed a commit to lucanos/bootstrap that referenced this pull request Oct 27, 2019
Kept `eslint@6.1.0` since the newer versions have a bug that affects us.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5
  
Shipped
Development

Successfully merging this pull request may close these issues.

None yet

3 participants