Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix centered modal scrolling issue #30244

Merged
merged 3 commits into from Feb 29, 2020
Merged

Fix centered modal scrolling issue #30244

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
19e365c
Fix centered modal scrolling issue
ysds Feb 19, 2020
07f02da
Merge branch 'master' into master-ysds-modal-scrolling-issue
XhmikosR Feb 22, 2020
8a4c924
Merge branch 'master' into master-ysds-modal-scrolling-issue
XhmikosR Feb 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions scss/_modal.scss
View file
Open in desktop
Expand Up @@ -83,6 +83,7 @@
&::before {
display: block; // IE10
height: subtract(100vh, $modal-dialog-margin * 2);
height: min-content; // Reset height to 0 except on IE
content: "";
}

Expand Down Expand Up @@ -216,6 +217,7 @@

&::before {
height: subtract(100vh, $modal-dialog-margin-y-sm-up * 2);
height: min-content;
}
}

Expand Down