Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v4: Remove appearance from date inputs #30361

Merged
merged 2 commits into from Apr 1, 2020
Merged

v4: Remove appearance from date inputs #30361

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68dd30d
Backport #30353
MartijnCuppens Mar 7, 2020
e2f2b17
Merge branch 'v4-dev' into v4dev-mc-backport-30353
XhmikosR Apr 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions scss/_forms.scss
View file
Open in desktop
Expand Up @@ -59,6 +59,15 @@
}
}

input[type="date"],
input[type="time"],
input[type="datetime-local"],
input[type="month"] {
&.form-control {
appearance: none; // Fix appearance for date inputs in Safari
}
}

select.form-control {
&:focus::-ms-value {
// Suppress the nested default white text on blue background highlight given to
Expand Down
12 changes: 0 additions & 12 deletions scss/_reboot.scss
View file
Open in desktop
Expand Up @@ -376,18 +376,6 @@ input[type="checkbox"] {
}


input[type="date"],
input[type="time"],
input[type="datetime-local"],
input[type="month"] {
// Remove the default appearance of temporal inputs to avoid a Mobile Safari
// bug where setting a custom line-height prevents text from being vertically
// centered within the input.
// See https://bugs.webkit.org/show_bug.cgi?id=139848
// and https://github.com/twbs/bootstrap/issues/11266
-webkit-appearance: listbox;
}

textarea {
overflow: auto; // Remove the default vertical scrollbar in IE.
// Textareas should really only resize vertically so they don't break their (horizontal) containers.
Expand Down