Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to string constants. #30490

Merged
merged 2 commits into from Mar 31, 2020
Merged

Switch to string constants. #30490

merged 2 commits into from Mar 31, 2020

Commits on Mar 31, 2020

  1. Switch to string constants. 

    This allows the minifier to mangle the constants. It also allows the linter to find unused strings properly.

While at it, remove a few unused properties.

File                        Before      After       Diff
--------------------------------------------------------
bootstrap.bundle.min.js     22.09 kB    21.13 kB    -0.96 kB (-4.35 %)
bootstrap.min.js            15.4 kB     14.46 kB    -0.94 kB (-3.86 %)
    @XhmikosR
    XhmikosR committed Mar 31, 2020
    Copy the full SHA
    89b9c9a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'v4-dev' into v4-dev-xmr-const-strings

    @XhmikosR
    XhmikosR committed Mar 31, 2020
    Copy the full SHA
    cdfcaee View commit details
    Browse the repository at this point in the history