Dropdown key events handling fix - v5 #30529
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eyboard events for <input>s and <textarea>s within dropdown-menu, except for escape key"
This was referenced Apr 7, 2020
|
Thanks for the PR. That being said, the ESLint issue is just a warning that could be tackled in a separate commit or PR. |
|
@luktom can you fetch upstream and rebase please? |
|
@XhmikosR conflicts with master resolved. |
|
@luktom can you try a proper rebase + squash and not a merge commit? |
|
Closing due to lack of response. If you can, please make a new clean PR later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see #30510 for details. Two new unit tests added. "npm run test" was finished without errors.
It was needed to add following fix from v4: #28912. After this cyclomatic complexity of
dataApiKeydownHandlerwas higher than allowed in your ESLint configuration, so I extracted_isDropDownCommandmethod.Additionally I fix some by catch error of variables assignment in "should ignore keyboard events for s and <textarea>s within dropdown-menu, except for escape key" test.
Fixes #30510