Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added border on focus of hambuger icon #30540

Closed
wants to merge 4 commits into from
Closed

added border on focus of hambuger icon #30540

wants to merge 4 commits into from

Conversation

TorRydberg
Copy link

@TorRydberg TorRydberg commented Apr 8, 2020

Fixes #30420

@TorRydberg TorRydberg requested a review from a team as a code owner April 8, 2020 18:22
@@ -40,3 +40,7 @@
line-height: 1;
color: $gray-900;
}

.bd-search-docs-toggle:focus {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this in under the selector in line 39 and make sure CI passes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed and commited again, all tests passed.

@XhmikosR XhmikosR added this to Inbox in v5 via automation Apr 8, 2020
@XhmikosR XhmikosR added this to Inbox in v4.5.0 via automation Apr 8, 2020
@MartijnCuppens
Copy link
Member

Closing this since #30036 already fixed this.

@TorRydberg TorRydberg deleted the torBranch branch April 9, 2020 16:05
@XhmikosR XhmikosR removed this from Inbox in v4.5.0 Apr 9, 2020
@XhmikosR XhmikosR removed this from Inbox in v5 Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation hamburger button lacks visible focus indication
3 participants