Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add role="dialog" in modals via JavaScript #30936

Merged
merged 3 commits into from Jun 4, 2020
Merged

Add role="dialog" in modals via JavaScript #30936

merged 3 commits into from Jun 4, 2020

Commits on May 31, 2020

  1. Add role="dialog" in the modal via script (Closes twbs#30773) 

    - Update documentation
- Update unit tests
    @rohit2sharma95
    rohit2sharma95 committed May 31, 2020
    Copy the full SHA
    aa395eb View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2020

  1. Merge branch 'master' into modal-role-via-script

    @XhmikosR
    XhmikosR committed Jun 4, 2020
    Copy the full SHA
    b533c52 View commit details
    Browse the repository at this point in the history

  2. Update the docs for modal 

    Update the docs to mention that role="dialog" is already added via JavaScript
    @rohit2sharma95
    rohit2sharma95 committed Jun 4, 2020
    Copy the full SHA
    a15df0a View commit details
    Browse the repository at this point in the history