Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid duplication of container breakpoints #30969

Merged
merged 5 commits into from Jun 13, 2020
Merged

Avoid duplication of container breakpoints #30969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9d1ac2b
🔥 Avoid duplication of container breakpoints
k-utsumi Jun 5, 2020
50af0ef
🔥 Delete make-container-max-widths mixin
k-utsumi Jun 5, 2020
a7fe9dc
♻️ More simplify built code
k-utsumi Jun 6, 2020
1754eb9
Merge branch 'v4-dev' into patch-1
k-utsumi Jun 12, 2020
5a22812
Merge branch 'v4-dev' into patch-1
XhmikosR Jun 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 1 addition & 5 deletions scss/_grid.scss
View file
Open in desktop
Expand Up @@ -4,11 +4,7 @@

@if $enable-grid-classes {
// Single container class with breakpoint max-widths
.container {
@include make-container();
@include make-container-max-widths();
}

.container,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built code diff
image

// 100% wide container at all breakpoints
.container-fluid {
@include make-container();
Expand Down
10 changes: 0 additions & 10 deletions scss/mixins/_grid.scss
View file
Open in desktop
Expand Up @@ -10,16 +10,6 @@
margin-left: auto;
}


// For each breakpoint, define the maximum width of the container in a media query
@mixin make-container-max-widths($max-widths: $container-max-widths, $breakpoints: $grid-breakpoints) {
@each $breakpoint, $container-max-width in $max-widths {
@include media-breakpoint-up($breakpoint, $breakpoints) {
max-width: $container-max-width;
}
}
}

@mixin make-row($gutter: $grid-gutter-width) {
display: flex;
flex-wrap: wrap;
Expand Down