Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

min-width: 0 on .col has too much side-effects #30979

Merged
merged 3 commits into from Jun 9, 2020

Conversation

ffoodd
Copy link
Member

@ffoodd ffoodd commented Jun 8, 2020

Closes #30852

For some reason I cannot revert the merged commit. So let's simply drop it.

Flexible items are flexible, so in order to fix what #30049 tried to fix: either use fixed width on pre, or let it wrap by using:

.col > pre {
  white-space: pre-wrap;
}

@mdo mdo added this to Inbox in v5 via automation Jun 8, 2020
@mdo mdo added this to Inbox in v4.5.1 via automation Jun 8, 2020
v5 automation moved this from Inbox to Approved Jun 9, 2020
@XhmikosR XhmikosR merged commit 32d18d1 into master Jun 9, 2020
v5 automation moved this from Approved to Shipped Jun 9, 2020
@XhmikosR XhmikosR deleted the master-fod-col-min-width branch June 9, 2020 18:49
@XhmikosR XhmikosR moved this from Inbox to Needs manual backport in v4.5.1 Jun 10, 2020
@XhmikosR
Copy link
Member

@ffoodd can you backport this manually please? It conflicts.

@XhmikosR XhmikosR removed this from Needs manual backport in v4.5.1 Jun 10, 2020
XhmikosR pushed a commit that referenced this pull request Jun 10, 2020
fix(grid)[manual backport]: zero min-width on .col has too much side-effects
@poebrand
Copy link

poebrand commented Jul 9, 2020

Hi @ffoodd and @mdo ,

According to https://github.com/twbs/bootstrap/releases , the last 4.x release was May 12th. However, this fix was put in place on June 9th.

Is it possible to get another 4.x release so this fix can go out? We just ran into the problem as well.

olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5
  
Shipped
Development

Successfully merging this pull request may close these issues.

Default Col min-width: 0 affects responsive behavior
5 participants