Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] ✨ Adjust container and add xs size #30996

Closed
wants to merge 1 commit into from
Closed

[Suggestion] ✨ Adjust container and add xs size #30996

wants to merge 1 commit into from

Conversation

k-utsumi
Copy link
Contributor

@k-utsumi k-utsumi commented Jun 9, 2020

Try and Suggestion PR for below issue for v5.
#30969

v4 .container, .container-[sm ~ xl] sample
https://jsfiddle.net/p2s1f9zn/

I don't understand the difference in behavior,
so I tried changing to a container class with different max-width.

Also, add the xs width to be used on the login screen, etc.

@k-utsumi k-utsumi requested a review from a team as a code owner June 9, 2020 20:22
@mdo
Copy link
Member

mdo commented Jun 10, 2020

No plans to change these or add another breakpoint at xs—we consider the default classes our "xs" tier.

Here's the container classes in effect. Basically they are 100% wide until a breakpoint.

Screen Shot 2020-06-09 at 5 29 31 PM

@mdo mdo closed this Jun 10, 2020
@k-utsumi k-utsumi deleted the feature/adjust-container branch June 26, 2020 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants