Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buttons plugin : avoid multiple change event trigger #31000

Merged
merged 8 commits into from Oct 2, 2020

Commits on Sep 14, 2020

  1. avoid multiple change event trigger :

    - add unit test to count how many event are thrown when widget contains multiple tags inside label
    - add a parameter to toggle, if click event is provided onto an input then don't trigger another change event already thrown by the browser
    - simplify the case where toggle interface is called click provide from input itself OR it's a button without label. If label is present, then browser propagate clic event from childrens thru label and then cause multiple calls to toggle
    - the test assume that `.btn` class is always set onto the label if there's one, otherwise need to update this plugin and look for label arround the input
    
    Test with keyboard, mouse and js clic call
    Lausselloic authored and XhmikosR committed Sep 14, 2020
    Copy the full SHA
    c3db204 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2020

  1. Copy the full SHA
    b2033e2 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2020

  1. Copy the full SHA
    a01b2bf View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    543c53f View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    b2b3607 View commit details
    Browse the repository at this point in the history
  4. fix latest lint error

    Lausselloic committed Oct 1, 2020
    Copy the full SHA
    4162e58 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2020

  1. Revert "replace avoidTriggerChange parameter by a css class `CLASS_…

    …NAME_CHANGING` on button" use a class variable instead
    
    This reverts commit a01b2bf.
    
    # Conflicts:
    #	js/src/button.js
    Lausselloic committed Oct 2, 2020
    Copy the full SHA
    1632d3c View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    8a37b3b View commit details
    Browse the repository at this point in the history