Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V4 dev backports and updates #31176

Merged
merged 7 commits into from Jul 6, 2020
Merged

V4 dev backports and updates #31176

merged 7 commits into from Jul 6, 2020

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Jun 25, 2020 •
edited

Notes:

  1. I can't seem to be able to find an Edge version older than 15 on BrowserStack, so I went with 15 which is the oldest one I see
  2. The Prevent overflowing static backdrop modal animation #30326 backport needs the test backported too. /CC @ysds for this

mdo and others added 4 commits June 25, 2020 15:28
@mdo @XhmikosR
Remove backdrop-filter from toasts
c005edf
@XhmikosR
BrowserStack: test on Edge 15
e4af24b
@XhmikosR
Backport #31135
671c95b 
* Move color utility callouts to start of page

Hierarchically/structurally, in the position they are currently at, the two callouts seem like they "belong" just to the "background color" section. Moving them to the start makes it clearer that those two callouts relate to everything in the page (both "Color" and "Background color" classes.

* Change heading level

otherwise the assistive technology callout looks like it's hierarchically under the "Dealing with specificity" heading
@XhmikosR
Backport #30326
bc37818 
Prevent overflowing static backdrop modal animation

TODO: backport the test too
@XhmikosR XhmikosR added the v4 label Jun 25, 2020
@ysds
Copy link
Member

ysds commented Jun 25, 2020

@XhmikosR Can I push the unit test to the v4-dev-xmr branch directly?

@XhmikosR
Copy link
Member Author

Of course :)

@ysds
Copy link
Member

ysds commented Jun 25, 2020

The #30326 backport needs the test backported too. /CC @ysds for this

Done :)

@XhmikosR XhmikosR marked this pull request as ready for review June 30, 2020 12:18
@XhmikosR XhmikosR requested review from a team as code owners June 30, 2020 12:18
@XhmikosR
Update Babel config (#31011)
8a5d45e 
* remove plugin-proposal-object-rest-spread
* add bugfixes
* `exclude: ['transform-typeof-symbol']` did nothing with our config
@XhmikosR XhmikosR force-pushed the v4-dev-xmr branch 2 times, most recently from bc634c0 to b0754b0 Compare July 3, 2020 06:12
@XhmikosR XhmikosR merged commit f40e1b6 into v4-dev Jul 6, 2020
@XhmikosR XhmikosR deleted the v4-dev-xmr branch July 6, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartijnCuppens MartijnCuppens MartijnCuppens approved these changes

@Johann-S Johann-S Awaiting requested review from Johann-S

Assignees
No one assigned
Labels
v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@XhmikosR @ysds @MartijnCuppens @mdo