Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore and deprecate make-container-max-widths mixin #31438

Merged
merged 4 commits into from Aug 6, 2020

Conversation

mdo
Copy link
Member

@mdo mdo commented Aug 5, 2020

We removed this to de-dupe our grid containers in our compiled CSS (see #30969) and I wasn't thinking when reviewing that it'd be a breaking change. We're sticking with not using the mixin, but adding the mixin back for others to use.

We may need to add a deprecation notice to it as well.

Fixes #31436, fixes #31440

@mdo mdo requested a review from a team as a code owner August 5, 2020 16:00
@mdo mdo added this to In progress in v4.5.3 via automation Aug 5, 2020
@grumbaut
Copy link

grumbaut commented Aug 5, 2020

This is currently a blocker on a rather urgent project. Any chance it will be merged soon? If not, I'll just require 4.5.0 exactly for now.

@mdo
Copy link
Member Author

mdo commented Aug 5, 2020

Hoping to do a v4.5.2 tomorrow to patch this. Doing some digging and testing other things out. Lock in at v4.5.0 exactly for now to keep yourself unblocked if you can.

@mdo mdo removed this from In progress in v4.5.3 Aug 5, 2020
@mdo mdo added this to Inbox in v5.0.0-alpha2 via automation Aug 5, 2020
@XhmikosR
Copy link
Member

XhmikosR commented Aug 6, 2020

@mdo Do we need the mixin in main, though? We could only target v4-dev where this was a breaking change, right?

@mdo
Copy link
Member Author

mdo commented Aug 6, 2020

Yup, we can retarget this one.

@XhmikosR
Copy link
Member

XhmikosR commented Aug 6, 2020

Let's add the deprecation warning too so that we are covered since the mixin is removed from v5. @twbs/css-review in case you can help us here to move faster.

@XhmikosR XhmikosR changed the base branch from main to v4-dev August 6, 2020 15:27
@XhmikosR XhmikosR changed the title Restore make-container-max-widths mixin Restore and deprecate make-container-max-widths mixin Aug 6, 2020
@XhmikosR XhmikosR added this to Inbox in v4.5.2 Aug 6, 2020
v5.0.0-alpha2 automation moved this from Inbox to Approved Aug 6, 2020
@XhmikosR XhmikosR removed this from Approved in v5.0.0-alpha2 Aug 6, 2020
@nh2
Copy link

nh2 commented Jan 12, 2022

Is there any documentation or an upgrade note what one should use instead of make-container-max-widths?

@rchulyada
Copy link

rchulyada commented Aug 9, 2022

would be good if there are list of depreciated and its replacement. Really annoying docs :( .
I replace with this media-breakpoint-up(sm) that what i needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v4.5.2
  
Shipped
Development

Successfully merging this pull request may close these issues.

4.5.1 Breaking change, removed Mixing make-container-max-widths
6 participants