Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change breadcrumb-item display to block #31692

Closed
wants to merge 1 commit into from
Closed

Conversation

mdo
Copy link
Member

@mdo mdo commented Sep 17, 2020

Fixes #29689 again, which was fixed in #29745 by @719media, but this introduced #31546. Undoing that last PR by setting this to block instead of inline-block (original value) or flex (current value).

Demo: https://codepen.io/emdeoh/pen/XWdPPxG

@mdo mdo requested a review from a team as a code owner September 17, 2020 20:41
@mdo mdo added this to Inbox in v5.0.0-alpha3 via automation Sep 17, 2020
@mdo
Copy link
Member Author

mdo commented Sep 17, 2020

Slating for Alpha 3 and v4.6 (not immediate v4.5.3).

@mdo mdo moved this from Inbox to Review in v5.0.0-alpha3 Sep 18, 2020
@XhmikosR
Copy link
Member

XhmikosR commented Sep 18, 2020

@mdo it seems the 4.6.0 project doesn't have any columns, so we might miss any projects you added?

EDIT: NVM, I added the columns

@XhmikosR XhmikosR added this to Inbox in v4.6.0 Sep 18, 2020
@MartijnCuppens
Copy link
Member

display: block will be moot, since the breadcrumb item is a child of a flex container. Also, this PR will reintroduce #29689, made this codepen to illustrate this:

https://codepen.io/MartijnCuppens/pen/PoNyzwx

It seems a good old float can help us out here, opened #31700 to illustate this.

@mdo mdo removed this from Review in v5.0.0-alpha3 Sep 18, 2020
@mdo mdo removed this from Inbox in v4.6.0 Sep 18, 2020
@mdo mdo closed this Sep 18, 2020
@mdo mdo deleted the breadcrumb-items-display branch September 18, 2020 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

breadcrumb spacing still an issue
3 participants