Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for data-interval on the first slide of carousel #31818

Merged
merged 14 commits into from Nov 1, 2020
Merged

Check for data-interval on the first slide of carousel #31818

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
4b11b31
check for data-interval on the first slide of carousel (#31716)
Oct 2, 2020
89f0023
add updateInterval method for elements of a carousel
Oct 2, 2020
a815d88
add test for carousel interval being set during cycle
Oct 2, 2020
4d1d401
undo editor lint
Oct 2, 2020
6e4ddf9
undo editor lint fully
Oct 2, 2020
842d8b3
Merge branch 'main' into carousel-data-bug
XhmikosR Oct 2, 2020
31459b9
update activeElement as soon as slide has finished (before transition…
Oct 2, 2020
ef0f426
only updateInterval before using it
Oct 3, 2020
c0ed1f0
return earlier when missing element
Oct 5, 2020
7fdd0af
Merge branch 'main' into carousel-data-bug
XhmikosR Oct 5, 2020
f8f9358
Merge branch 'main' into carousel-data-bug
XhmikosR Oct 5, 2020
46cad45
Merge branch 'main' into carousel-data-bug
XhmikosR Oct 7, 2020
9adb0ea
Merge branch 'main' into carousel-data-bug
XhmikosR Oct 19, 2020
0b835b6
Merge branch 'main' into carousel-data-bug
XhmikosR Nov 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions js/src/carousel.js
View file
Open in desktop
Expand Up @@ -181,6 +181,16 @@ class Carousel {
}

if (this._config && this._config.interval && !this._isPaused) {
this._activeElement = SelectorEngine.findOne(SELECTOR_ACTIVE_ITEM, this._element)

if (this._activeElement) {
const activeElementInterval = parseInt(this._activeElement.getAttribute('data-interval'), 10)

if (activeElementInterval) {
this._config.interval = activeElementInterval
}
}
Johann-S marked this conversation as resolved.
Show resolved Hide resolved

this._interval = setInterval(
(document.visibilityState ? this.nextWhenVisible : this.next).bind(this),
this._config.interval
Expand Down