Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add callouts about using light colors ideally on a dark background #32040

Merged
merged 3 commits into from Nov 2, 2020

Conversation

patrickhlauke
Copy link
Member

would be even better to show those buttons on a dark background, but i assume that'd require a lot more logic behind the scenes (to only show the outline buttons that are contrasty enough against white on a white background, and the others on a dark background)

@ffoodd
Copy link
Member

ffoodd commented Nov 2, 2020

With #30044 merged a few days ago, it might be quite trivial to handle backgrounds (but would require to use some kind of containers to apply backgrounds). However the callout is a good idea :)

v5.0.0-alpha3 automation moved this from Inbox to Approved Nov 2, 2020
@patrickhlauke
Copy link
Member Author

Just realised we should probably do the same for https://v5.getbootstrap.com/docs/5.0/helpers/colored-links/ ... i'll add another commit here

@patrickhlauke patrickhlauke changed the title Add callout about using light colors ideally on a dark background Add callouts about using light colors ideally on a dark background Nov 2, 2020
@patrickhlauke patrickhlauke added this to Inbox in v4.6.0 via automation Nov 2, 2020
@mdo
Copy link
Member

mdo commented Nov 2, 2020

Would be very nice to add a background element around them if needed based on the contrast colors. A callout like this feels unnecessary IMO, but I'm down for whatever.

@patrickhlauke
Copy link
Member Author

let's do callout just now, and then somebody cleverer than me can work out how to do a conditional bit of light vs dark background

@patrickhlauke patrickhlauke merged commit 6682bba into main Nov 2, 2020
v5.0.0-alpha3 automation moved this from Approved to Shipped Nov 2, 2020
@patrickhlauke patrickhlauke deleted the patrickhlauke-docs-buttons-outline-callout branch November 2, 2020 20:39
@XhmikosR
Copy link
Member

XhmikosR commented Nov 3, 2020

@patrickhlauke this needs a manual backport, can you do it please and ping me?

@XhmikosR XhmikosR moved this from Inbox to Needs manual backport in v4.6.0 Nov 3, 2020
@patrickhlauke
Copy link
Member Author

@XhmikosR done - #32054

@XhmikosR XhmikosR removed this from Needs manual backport in v4.6.0 Nov 3, 2020
XhmikosR pushed a commit that referenced this pull request Nov 3, 2020
Add callouts about using light colors ideally on a dark background
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.0.0-alpha3
  
Shipped
Development

Successfully merging this pull request may close these issues.

None yet

4 participants