Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carousel: use buttons, not links, for prev/next controls #32627

Merged
merged 20 commits into from Jan 27, 2021
Merged

Carousel: use buttons, not links, for prev/next controls #32627

merged 20 commits into from Jan 27, 2021

Commits on Dec 27, 2020

  1. Carousel: use buttons, not links, for prev/next 

    - expand the styles to neutralise border/background
- change docs page
- add extra unit test to check that links or buttons work as controls
- modify visual test to use buttons as well
    @patrickhlauke
    patrickhlauke committed Dec 27, 2020
    Configuration menu
    Copy the full SHA
    f328d01 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2020

  1. Merge branch 'main' into patrickhlauke-carousel

    @patrickhlauke
    patrickhlauke committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    9116ff2 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2020

  1. Merge branch 'main' into patrickhlauke-carousel

    @patrickhlauke
    patrickhlauke committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    b749662 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into patrickhlauke-carousel

    @patrickhlauke
    patrickhlauke committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    50ac915 View commit details
    Browse the repository at this point in the history

  3. Use buttons for newly-merged extra carousel

    @patrickhlauke
    patrickhlauke committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    d753f4a View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2021

  1. Merge branch 'main' into patrickhlauke-carousel

    @patrickhlauke
    patrickhlauke committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    7b718ca View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2021

  1. Edit carousel examples 

    - use buttons instead of links for prev/next
- remove `role="button"` from links that are actually links
    @patrickhlauke
    patrickhlauke committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    13eb932 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into patrickhlauke-carousel

    @patrickhlauke
    patrickhlauke committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    eda76bb View commit details
    Browse the repository at this point in the history

  3. Clarify that controls can be button or link 

    also adds code ticks to `id`
    @patrickhlauke
    patrickhlauke committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    c72d23b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'patrickhlauke-carousel' of https://github.com/twbs/boot… 

    …strap into patrickhlauke-carousel
    @patrickhlauke
    patrickhlauke committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    1493ac0 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2021

  1. Merge branch 'main' into patrickhlauke-carousel

    @patrickhlauke
    patrickhlauke committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    a2447ba View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2021

  1. Merge branch 'main' into patrickhlauke-carousel

    @patrickhlauke
    patrickhlauke committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    7e1855d View commit details
    Browse the repository at this point in the history

  2. Revert separate/unrelated change to CTA links 

    moved to separate PR
    @patrickhlauke
    patrickhlauke committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    80f5812 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2021

  1. Merge branch 'main' into patrickhlauke-carousel

    @patrickhlauke
    patrickhlauke committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    c9cbb17 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2021

  1. Merge branch 'main' into patrickhlauke-carousel

    @rohit2sharma95
    rohit2sharma95 committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    6271d10 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2021

  1. Update site/content/docs/5.0/components/carousel.md 

    Co-authored-by: Mark Otto <markd.otto@gmail.com>
    @patrickhlauke @mdo
    patrickhlauke and mdo committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    c49d354 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into patrickhlauke-carousel

    @patrickhlauke
    patrickhlauke committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    6373ac1 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2021

  1. Merge branch 'main' into patrickhlauke-carousel

    @XhmikosR
    XhmikosR committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    e4414c7 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2021

  1. Merge branch 'main' into patrickhlauke-carousel

    @patrickhlauke
    patrickhlauke committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    47657bf View commit details
    Browse the repository at this point in the history

  2. Explicitly set padding to 0 to prevent dipping/moving on active in Fi… 

    …refox
    @patrickhlauke
    patrickhlauke committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    3f0f00a View commit details
    Browse the repository at this point in the history