Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Tweak the wording for collapse to indicate button is preferred/more semantic #32632

Merged
merged 3 commits into from Jan 5, 2021
Merged

Docs: Tweak the wording for collapse to indicate button is preferred/more semantic #32632

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f070c72
Tweak the wording for collapse to indicate button is preferred/more s…
patrickhlauke Dec 27, 2020
65b4792
Merge branch 'main' into patrickhlauke-tweak-collapse
patrickhlauke Dec 29, 2020
ec776b1
Merge branch 'main' into patrickhlauke-tweak-collapse
XhmikosR Jan 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion site/content/docs/5.0/components/collapse.md
View file
Open in desktop
Expand Up @@ -22,7 +22,7 @@ Click the buttons below to show and hide another element via class changes:
- `.collapsing` is applied during transitions
- `.collapse.show` shows content

You can use a link with the `href` attribute, or a button with the `data-bs-target` attribute. In both cases, the `data-bs-toggle="collapse"` is required.
Generally, we recommend using a button with the `data-bs-target` attribute. While not recommended from a semantic point of view, you can also use a link with the `href` attribute (and a `role="button"`). In both cases, the `data-bs-toggle="collapse"` is required.

{{< example >}}
<p>
Expand Down