Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v4: Add an actual data-touch="false" example in the carousel docs #32639

Merged
merged 8 commits into from Jan 5, 2021
Merged

v4: Add an actual data-touch="false" example in the carousel docs #32639

merged 8 commits into from Jan 5, 2021

Commits on Dec 28, 2020

  1. v4: Add an actual data-touch="false" example in the carousel docs 

    Backport of #32638
    @patrickhlauke
    patrickhlauke committed Dec 28, 2020
    Copy the full SHA
    ba6182a View commit details
    Browse the repository at this point in the history

  2. Remove data-ride from example carousel

    @patrickhlauke
    patrickhlauke committed Dec 28, 2020
    Copy the full SHA
    694f9ca View commit details
    Browse the repository at this point in the history

  3. Correct attribute table explanation and remove slide class from example 

    i believe the correct option is `slide` here, not `ride`.
the `if "carousel"` bit was rather unclear/confusing
    @patrickhlauke
    patrickhlauke committed Dec 28, 2020
    Copy the full SHA
    4cd5e47 View commit details
    Browse the repository at this point in the history

  4. Edits... 

    sorry, trying to make sense of our quirky carousel stuff, it seems some illogical things have been there ever since
    @patrickhlauke
    patrickhlauke committed Dec 28, 2020
    Copy the full SHA
    49eafe1 View commit details
    Browse the repository at this point in the history

  5. Add data-interval to suppress autoplay

    @patrickhlauke
    patrickhlauke committed Dec 28, 2020
    Copy the full SHA
    3f19870 View commit details
    Browse the repository at this point in the history

  6. Tweak carousel options formatting

    @patrickhlauke
    patrickhlauke committed Dec 28, 2020
    Copy the full SHA
    ae54c9b View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2021

  1. Update site/content/docs/4.5/components/carousel.md 

    Co-authored-by: Mark Otto <markd.otto@gmail.com>
    @patrickhlauke @mdo
    patrickhlauke and mdo committed Jan 5, 2021
    Copy the full SHA
    725ba2c View commit details
    Browse the repository at this point in the history

  2. Tweak language 

    mostly based on @mdo's suggestion, but also adds the word "attribute" after `data-ride` for better flow/legibility
    @patrickhlauke
    patrickhlauke committed Jan 5, 2021
    Copy the full SHA
    9b63d69 View commit details
    Browse the repository at this point in the history