Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove explicit suppression of focus outline #33029

Merged
merged 3 commits into from
Feb 11, 2021
+0 −14
Merged

Remove explicit suppression of focus outline #33029

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc54152
Remove explicit suppression of focus outline
patrickhlauke Feb 9, 2021
81e1bc2
Merge branch 'main' into patrickhlauke-v5-remove-forced-outline-suppr…
patrickhlauke Feb 9, 2021
407420f
Merge branch 'main' into patrickhlauke-v5-remove-forced-outline-suppr…
mdo Feb 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 0 additions & 14 deletions scss/_reboot.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,20 +57,6 @@ body {
}


// Future-proof rule: in browsers that support :focus-visible, suppress the focus outline
// on elements that programmatically receive focus but wouldn't normally show a visible
// focus outline. In general, this would mean that the outline is only applied if the
// interaction that led to the element receiving programmatic focus was a keyboard interaction,
// or the browser has somehow determined that the user is primarily a keyboard user and/or
// wants focus outlines to always be presented.
// See https://developer.mozilla.org/en-US/docs/Web/CSS/:focus-visible
// and https://developer.paciellogroup.com/blog/2018/03/focus-visible-and-backwards-compatibility/

[tabindex="-1"]:focus:not(:focus-visible) {
outline: 0 !important;
}


// Content grouping
//
// 1. Reset Firefox's gray color
Expand Down