Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make carousel indicators actual buttons (backport to v4) #33166

Closed
wants to merge 2 commits into from
Closed

Make carousel indicators actual buttons (backport to v4) #33166

wants to merge 2 commits into from

Conversation

patrickhlauke
Copy link
Member

Manual backport of #32661

@patrickhlauke patrickhlauke requested review from a team as code owners February 21, 2021 01:59
@patrickhlauke patrickhlauke added this to Inbox in v4.6.1 via automation Feb 21, 2021
@patrickhlauke patrickhlauke force-pushed the patrickhlauke-carousel-indicators-v4 branch 6 times, most recently from 895a256 to b9df8ff Compare February 21, 2021 03:20
XhmikosR
XhmikosR reviewed Feb 21, 2021
View reviewed changes
js/src/carousel.js Outdated Show resolved Hide resolved
@XhmikosR
Copy link
Member

Need another approval just in case @rohit2sharma95.

@XhmikosR XhmikosR marked this pull request as draft March 11, 2021 06:48
@XhmikosR XhmikosR force-pushed the patrickhlauke-carousel-indicators-v4 branch from 2975ddc to dccbc35 Compare March 11, 2021 06:48
@XhmikosR
Copy link
Member

I marked it as draft; I'm not 100% sure about the CSS changes and specificity since people might override the selectors.

XhmikosR
XhmikosR requested changes Mar 11, 2021
View reviewed changes
Copy link
Member

@XhmikosR XhmikosR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporarily blocking the PR

@patrickhlauke patrickhlauke marked this pull request as ready for review April 11, 2021 10:26
@patrickhlauke
Copy link
Member Author

Setting this to ready for review, but worth deciding if we're going ahead with this backport or scrapping it.

@patrickhlauke @XhmikosR
Manual backport of #32661
759bc24 
Make carousel indicators actual buttons
@XhmikosR XhmikosR force-pushed the patrickhlauke-carousel-indicators-v4 branch from ee12e9b to 759bc24 Compare October 8, 2021 15:09
@XhmikosR XhmikosR requested a review from mdo October 8, 2021 15:17
@mdo mdo added this to In progress in v4.6.2 via automation Oct 9, 2021
@mdo mdo removed this from Inbox in v4.6.1 Oct 9, 2021
@patrickhlauke
Copy link
Member Author

@mdo @XhmikosR your call if this is too much of a breaking change or not. if we feel it is, suggest just closing the PR and not backporting.

@mdo
Copy link
Member

mdo commented May 24, 2022

Revisiting this, I think we will have to skip it for the breaking changes in those selectors. So sorry for the wasted effort so long ago! 😓

@mdo mdo closed this May 24, 2022
@mdo mdo removed this from In progress in v4.6.2 May 24, 2022
@XhmikosR XhmikosR deleted the patrickhlauke-carousel-indicators-v4 branch May 24, 2022 18:14
@patrickhlauke
Copy link
Member Author

no worries, 5 is where it's at now anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XhmikosR XhmikosR XhmikosR requested changes

@rohit2sharma95 rohit2sharma95 rohit2sharma95 approved these changes

@mdo mdo Awaiting requested review from mdo

Assignees
No one assigned
Labels
v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@patrickhlauke @XhmikosR @mdo @rohit2sharma95