Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offcanvas must not enforce focus if option 'scroll' is true #33445

Closed

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented Mar 23, 2021

No description provided.

@GeoSot GeoSot requested a review from a team as a code owner March 23, 2021 16:51
@GeoSot GeoSot marked this pull request as draft March 23, 2021 22:39
@GeoSot GeoSot force-pushed the gs-regression-allow-offcanvas-to-not-enforce-focus branch from f2d1492 to 1bb1df3 Compare March 23, 2021 23:48
@GeoSot GeoSot changed the title Offcanvas option to enforce focus or not Offcanvas must not enforce focus if option 'scroll' is true Mar 24, 2021
@GeoSot GeoSot added this to Inbox in v5.0.0 via automation Mar 24, 2021
@XhmikosR XhmikosR moved this from Inbox to Review in v5.0.0 Apr 18, 2021
@XhmikosR
Copy link
Member

This doesn't seem quite right yet; if you go to the docs page and click on the first example buttons, the live example will close.

@XhmikosR XhmikosR removed this from Review in v5.0.0 Apr 18, 2021
@GeoSot GeoSot closed this Apr 18, 2021
@GeoSot
Copy link
Member Author

GeoSot commented Apr 18, 2021

Start again on #33677, keeping only the proper change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants