Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Icons to alert component #33536

Closed
wants to merge 4 commits into from
Closed

Adding Icons to alert component #33536

wants to merge 4 commits into from

Conversation

devhoussam
Copy link
Contributor

@devhoussam devhoussam commented Apr 1, 2021 •
edited by XhmikosR

@devhoussam devhoussam requested a review from a team as a code owner April 1, 2021 10:25
@XhmikosR
Copy link
Member

XhmikosR commented Apr 1, 2021

Unsure if we need sub at all or if such change should be in this PR.

/CC @mdo

mdo
mdo requested changes Apr 9, 2021
View reviewed changes
Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sub isn't needed. Change the size of the icon to 24px and it'll line up great. Unsure if anything else is needed beyond that.

@mdo mdo mentioned this pull request Apr 19, 2021
Merged
@mdo
Copy link
Member

mdo commented Apr 19, 2021

#33690

@mdo mdo closed this Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo requested changes

Assignees
No one assigned
Labels
docs v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

V5 Alerts Component : Add the icon space
4 participants
@devhoussam @XhmikosR @mdo @themes4all