Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clicking an item in navbar dropdown should not collapse the dropdown in firefox #33643

Merged
merged 2 commits into from Apr 18, 2021
Merged

fix: clicking an item in navbar dropdown should not collapse the dropdown in firefox #33643

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b66ee5
fix: clicking an item in navbar dropdown collapses the dropdown in fi…
alpadev Apr 15, 2021
b985714
Merge branch 'main' into fix-dropdown-select-ff
XhmikosR Apr 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/src/dropdown.js
View file
Open in desktop
Expand Up @@ -415,7 +415,7 @@ class Dropdown extends BaseComponent {
return
}

if (/input|select|textarea|form/i.test(event.target.tagName)) {
if (/input|select|option|textarea|form/i.test(event.target.tagName)) {
return
}
}
Expand Down