Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Sidebars example to fix dividers and rendering on Chrome #33859

Merged
merged 1 commit into from
May 13, 2021
Merged

Update Sidebars example to fix dividers and rendering on Chrome #33859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions site/content/docs/5.0/examples/sidebars/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
<main>
<h1 class="visually-hidden">Sidebars examples</h1>

<div class="d-flex flex-column p-3 text-white bg-dark" style="width: 280px;">
<div class="d-flex flex-column flex-shrink-0 p-3 text-white bg-dark" style="width: 280px;">
<a href="/" class="d-flex align-items-center mb-3 mb-md-0 me-md-auto text-white text-decoration-none">
<svg class="bi me-2" width="40" height="32"><use xlink:href="#bootstrap"/></svg>
<span class="fs-4">Sidebar</span>
Expand Down Expand Up @@ -126,7 +126,7 @@ <h1 class="visually-hidden">Sidebars examples</h1>

<div class="b-example-divider"></div>

<div class="d-flex flex-column p-3 bg-light" style="width: 280px;">
<div class="d-flex flex-column flex-shrink-0 p-3 bg-light" style="width: 280px;">
<a href="/" class="d-flex align-items-center mb-3 mb-md-0 me-md-auto link-dark text-decoration-none">
<svg class="bi me-2" width="40" height="32"><use xlink:href="#bootstrap"/></svg>
<span class="fs-4">Sidebar</span>
Expand Down Expand Up @@ -182,7 +182,7 @@ <h1 class="visually-hidden">Sidebars examples</h1>

<div class="b-example-divider"></div>

<div class="d-flex flex-column bg-light" style="width: 4.5rem;">
<div class="d-flex flex-column flex-shrink-0 bg-light" style="width: 4.5rem;">
<a href="/" class="d-block p-3 link-dark text-decoration-none" title="Icon-only" data-bs-toggle="tooltip" data-bs-placement="right">
<svg class="bi" width="40" height="32"><use xlink:href="#bootstrap"/></svg>
<span class="visually-hidden">Icon-only</span>
Expand Down Expand Up @@ -230,7 +230,7 @@ <h1 class="visually-hidden">Sidebars examples</h1>

<div class="b-example-divider"></div>

<div class="p-3 bg-white" style="width: 280px;">
<div class="flex-shrink-0 p-3 bg-white" style="width: 280px;">
<a href="/" class="d-flex align-items-center pb-3 mb-3 link-dark text-decoration-none border-bottom">
<svg class="bi me-2" width="30" height="24"><use xlink:href="#bootstrap"/></svg>
<span class="fs-5 fw-semibold">Collapsible</span>
Expand Down Expand Up @@ -293,7 +293,7 @@ <h1 class="visually-hidden">Sidebars examples</h1>

<div class="b-example-divider"></div>

<div class="d-flex flex-column align-items-stretch bg-white" style="width: 380px;">
<div class="d-flex flex-column align-items-stretch flex-shrink-0 bg-white" style="width: 380px;">
<a href="/" class="d-flex align-items-center flex-shrink-0 p-3 link-dark text-decoration-none border-bottom">
<svg class="bi me-2" width="30" height="24"><use xlink:href="#bootstrap"/></svg>
<span class="fs-5 fw-semibold">List group</span>
Expand Down
17 changes: 12 additions & 5 deletions site/content/docs/5.0/examples/sidebars/sidebars.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,26 @@
body {
min-height: 100vh;
min-height: -webkit-fill-available;
}

html {
height: -webkit-fill-available;
}

main {
display: flex;
flex-wrap: nowrap;
height: 100vh;
height: -webkit-fill-available;
max-height: 100vh;
overflow-x: auto;
overflow-y: hidden;
}
main > * {
flex-shrink: 0;
min-height: -webkit-fill-available;
}

.b-example-divider {
flex-shrink: 0;
width: 1.5rem;
height: 100%;
height: 100vh;
background-color: rgba(0, 0, 0, .1);
border: solid rgba(0, 0, 0, .15);
border-width: 1px 0;
Expand Down