Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert :read-only selector back to [readonly] #33961

Merged
merged 2 commits into from May 13, 2021

Conversation

mdo
Copy link
Member

@mdo mdo commented May 13, 2021

Reverts #33642. Fixes #33860, fixes #33925.

@mdo mdo requested a review from a team as a code owner May 13, 2021 05:05
@mdo mdo added this to Inbox in v5.0.1 via automation May 13, 2021
@mdo mdo mentioned this pull request May 13, 2021
@XhmikosR XhmikosR requested a review from ffoodd May 13, 2021 05:20
v5.0.1 automation moved this from Inbox to Approved May 13, 2021
@XhmikosR XhmikosR merged commit 1e4b924 into main May 13, 2021
v5.0.1 automation moved this from Approved to Done May 13, 2021
@XhmikosR XhmikosR deleted the revert-33642-use-read-only-for-comsistency branch May 13, 2021 14:01
@arcanisgk
Copy link

why isn't there a design difference between read-only and disabled?

The difference between disabled and readonly is that read-only controls can still function and are still focusable, whereas disabled controls can not receive focus and are not submitted with the form and generally do not function as controls until they are enabled.

The idea of using bootstrap is that the designs of the web pages are similar and in the best of cases that the elements are intuitive; so being an end user and seeing a disabled or read-only field, I'm not getting any visual feedback...

would it be possible to use a specific pointer for each type of situation?

for example field disabled can use cursor: not-allowed;

for example field read-only i have not find a default cursor, and cant find any related icon in BS ICON but i search in other solution and find one that i can use in a custom from FontAwesome:

for example font awesome have this icon:

image

in the end I was hoping that this could be fixed within BS as part of its visual aid to the end user.

@mdo
Copy link
Member Author

mdo commented Jul 4, 2022

@arcanisgk Please don't add unrelated comments to closed pull requests. You won't likely get a reply from anyone. This was also addressed to an extent in #36499 and will ship soon.

@twbs twbs locked and limited conversation to collaborators Jul 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
v5.0.1
  
Done
Development

Successfully merging this pull request may close these issues.

Readonly inputs shouldn't be grayed out <select> with form-control have background color as :read-only
4 participants