Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make text decoration consistent with other anchors #34475

Merged

Conversation

andrewpucci
Copy link
Contributor

This PR makes the hover state for anchors with class card-link match the text-decoration set in other hover states in #30389. In effect, this will make it so card links will be underlined on hover, by default.

Fixes #34474

@andrewpucci andrewpucci requested a review from a team as a code owner July 10, 2021 22:17
@mdo mdo added this to In progress in v5.2.0 via automation Jul 26, 2021
v5.2.0 automation moved this from In progress to Reviewer approved Jul 28, 2021
@XhmikosR XhmikosR removed this from Reviewer approved in v5.2.0 Jul 28, 2021
@XhmikosR XhmikosR added this to Inbox in v5.1.0 via automation Jul 28, 2021
@XhmikosR XhmikosR moved this from Inbox to Approved in v5.1.0 Jul 28, 2021
@XhmikosR XhmikosR merged commit fd9285b into twbs:main Jul 28, 2021
v5.1.0 automation moved this from Approved to Done Jul 28, 2021
marvin-hinkley-vortx pushed a commit to Vortx-Inc/bootstrap that referenced this pull request Aug 18, 2021
Fixes twbs#34474

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v5.1.0
  
Done
Development

Successfully merging this pull request may close these issues.

Card link not underlined on hover
4 participants