Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow data-toggle="dropdown" and form click events to bubble (Backport #33442) #35163

Closed
wants to merge 1 commit into from

Conversation

GeoSot
Copy link
Member

@GeoSot GeoSot commented Oct 11, 2021

Allow data-toggle="dropdown" and form click events to bubble (Backport of #33442)

  • remove stopPropagation from button click event
  • test for delegated click events
  • ensure button children can open menu
  • test to ensure clicking button opens the menu
  • check current element and parents
  • allow dropdown form click events to bubble

Needs

  • check todo composedPath not supported on IE
  • check tests

…t of #33442)

* remove stopPropagation from button click event

* test for delegated click events

* ensure button children can open menu

* test to ensure clicking button opens the menu

* check current element and parents

* allow dropdown form click events to bubble
@GeoSot GeoSot added this to Inbox in v4.6.1 via automation Oct 11, 2021
@XhmikosR XhmikosR changed the title Allow data-toggle="dropdown" and form click events to bubble (Backpor… Allow data-toggle="dropdown" and form click events to bubble (Backport of #33442) Oct 22, 2021
@XhmikosR XhmikosR changed the title Allow data-toggle="dropdown" and form click events to bubble (Backport of #33442) Allow data-toggle="dropdown" and form click events to bubble (Backport #33442) Oct 22, 2021
@XhmikosR XhmikosR removed this from Inbox in v4.6.1 Oct 26, 2021
@XhmikosR XhmikosR added this to In progress in v4.6.2 via automation Oct 26, 2021
@GeoSot GeoSot closed this Jan 30, 2022
@XhmikosR XhmikosR removed this from In progress in v4.6.2 Feb 2, 2022
@GeoSot GeoSot deleted the gs/v4/dropdown-backport-bubble-click-events branch February 17, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant