Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add info about dependency management for vanilla ESM in browser #36017

Closed
wants to merge 8 commits into from

Conversation

earcam
Copy link
Contributor

@earcam earcam commented Mar 14, 2022

Please see #31944

Docs: dependencies mgmt for vanilla ESM in browser
@XhmikosR
Copy link
Member

Thanks for the PR!

I notice two issues:

  1. since the SRI hash changes on previews (because we build the latest code), we are getting SRI mismatch errors there. Unsure how to handle this, because hardcoding the values isn't an option :/

  2. I'm also getting JS errors when I click the button with all browsers I tried:

    Uncaught TypeError: Popper.createPopper is not a function
        at Popover.show (tooltip.js:273:29)
        at Popover._enter (tooltip.js:598:15)
        at Popover.toggle (tooltip.js:191:17)
        at HTMLButtonElement.<anonymous> (tooltip.js:532:107)
        at HTMLButtonElement.i (event-handler.js:102:15)
    

@XhmikosR XhmikosR changed the title Doc Update: dependency management for vanilla ESM in browser docs: add info about dependency management for vanilla ESM in browser Mar 15, 2022
@mdo
Copy link
Member

mdo commented May 16, 2022

I put together a test of this over at https://github.com/twbs/examples/tree/main/sass-js-esm. Loving the potential of this, and agreed our docs needs more guidance on the options available to developers for consuming our JS.

@mdo mdo added this to In progress in v5.2.0-stable via automation May 16, 2022
@mdo
Copy link
Member

mdo commented May 20, 2022

Replaced by #36414.

@mdo mdo closed this May 20, 2022
v5.2.0-stable automation moved this from In progress to Done May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.2.0-stable
  
Done
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants